Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[STM32L4] Set NVIC_RAM_VECTOR_ADDRESS to 0x10000000 #1553

Merged
merged 1 commit into from
Feb 22, 2016
Merged

[STM32L4] Set NVIC_RAM_VECTOR_ADDRESS to 0x10000000 #1553

merged 1 commit into from
Feb 22, 2016

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Feb 19, 2016

Fix issue #1413
Fix issue #1509

@bcostm bcostm changed the title Set NVIC_RAM_VECTOR_ADDRESS to 0x10000000 [STM32L4] Set NVIC_RAM_VECTOR_ADDRESS to 0x10000000 Feb 19, 2016
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 20, 2016

Please consider writing a test for this feature. Did you use any existing test to verify this? There's interruptIn and InterruptIn2 test units.

@sg- @bridadan We shall provide some docs in test/ folder to encourage writing tests. I dont see much docs in the test units there.

@bcostm
Copy link
Contributor Author

bcostm commented Feb 21, 2016

I just checked the Nucleo_interrupt example but I didn't run the mbed tests. I'll do it too. But I assure you that the 0x20000000 is really a mistake...

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2016

But I assure you that the 0x20000000 is really a mistake..

Yes, therefore the test should be there and run.

@bcostm
Copy link
Contributor Author

bcostm commented Feb 22, 2016

I ran the InterruptIn test. The InterruptIn2 test is not automated for these boards nor the Interrupt_chaining test. Nevertheless the InterruptIn test shows well the correction.

ORIGINAL with #define NVIC_RAM_VECTOR_ADDRESS (0x20000000) for uARM

+---------+---------------------+-----------+---------+------------------+--------------------+---------------+-------+
| Result  | Target              | Toolchain | Test ID | Test Description | Elapsed Time (sec) | Timeout (sec) | Loops |
+---------+---------------------+-----------+---------+------------------+--------------------+---------------+-------+
| TIMEOUT | NUCLEO_L476RG[F32D] | uARM      | MBED_A7 | InterruptIn      |       30.43        |       15      |  0/1  |
| TIMEOUT | NUCLEO_L476RG[F32D] | ARM       | MBED_A7 | InterruptIn      |       30.38        |       15      |  0/1  |
+---------+---------------------+-----------+---------+------------------+--------------------+---------------+-------+

CORRECTION
#define NVIC_RAM_VECTOR_ADDRESS (0x10000000) for uARM

+--------+---------------------+-----------+---------+------------------+--------------------+---------------+-------+
| Result | Target              | Toolchain | Test ID | Test Description | Elapsed Time (sec) | Timeout (sec) | Loops |
+--------+---------------------+-----------+---------+------------------+--------------------+---------------+-------+
| OK     | NUCLEO_L476RG[F32D] | uARM      | MBED_A7 | InterruptIn      |        8.8         |       15      |  1/1  |
| OK     | NUCLEO_L476RG[F32D] | ARM       | MBED_A7 | InterruptIn      |        8.74        |       15      |  1/1  |
+--------+---------------------+-----------+---------+------------------+--------------------+---------------+-------+

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 22, 2016

Thanks!

@bridadan Please have a look at the above

0xc0170 added a commit that referenced this pull request Feb 22, 2016
@0xc0170
Merge pull request #1553 from bcostm/master
471fa67 
[STM32L4] Set NVIC_RAM_VECTOR_ADDRESS to 0x10000000
@0xc0170 0xc0170 merged commit 471fa67 into ARMmbed:master Feb 22, 2016
@bridadan
Copy link
Contributor

@0xc0170 InterruptIn results look good.

Regarding InterruptIn2, that test looks fairly unnecessary, perharps we can move/remove it?

Regarding Interrupt_chaining, it looks like it should either be expanded to include all platforms or modified to be general? It looks the #if defined(TARGET) calls are used to resolve IRQ names and LED pins. We can probably figure out the LED stuff, but is there a general IRQ name we can use so we don't have to use #if defined(TARGET)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcostm @0xc0170 @bridadan